Reintroduced the tab key as a way to confirm mentions selection.

ckeditor · Mar 30, 2020 · ef62d5a · ef62d5a
1 parent e71b42c
commit ef62d5a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/mentionui.js b/src/mentionui.js
@@ -33,6 +33,7 @@ const handledKeyCodes = [
 	keyCodes.arrowup,
 	keyCodes.arrowdown,
 	keyCodes.enter,
+	keyCodes.tab,
 	keyCodes.esc
 ];
 
@@ -119,7 +120,7 @@ export default class MentionUI extends Plugin {
 					this._mentionsView.selectPrevious();
 				}
 
-				if ( data.keyCode == keyCodes.enter ) {
+				if ( data.keyCode == keyCodes.enter || data.keyCode == keyCodes.tab ) {
 					this._mentionsView.executeSelected();
 				}
 

diff --git a/tests/mentionui.js b/tests/mentionui.js
@@ -1566,6 +1566,8 @@ describe( 'MentionUI', () => {
 
 			describe( 'on "execute" keys', () => {
 				testExecuteKey( 'enter', keyCodes.enter, feedItems );
+
+				testExecuteKey( 'tab', keyCodes.tab, feedItems );
 			} );
 		} );
 
@@ -1714,6 +1716,8 @@ describe( 'MentionUI', () => {
 
 				describe( 'on "execute" keys', () => {
 					testExecuteKey( 'enter', keyCodes.enter, issues );
+
+					testExecuteKey( 'tab', keyCodes.tab, issues );
 				} );
 			} );
 		} );
@@ -1835,6 +1839,8 @@ describe( 'MentionUI', () => {
 
 				describe( 'on "execute" keys', () => {
 					testExecuteKey( 'enter', keyCodes.enter, issues );
+
+					testExecuteKey( 'tab', keyCodes.tab, issues );
 				} );
 
 				describe( 'mouse', () => {