Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

I/6109: Make SpecialCharactersNavigationView an instance of the new FormHeaderView UI #15

Merged
merged 6 commits into from
Mar 26, 2020
Merged

I/6109: Make SpecialCharactersNavigationView an instance of the new FormHeaderView UI #15

merged 6 commits into from
Mar 26, 2020

Conversation

panr
Copy link
Contributor

@panr panr commented Mar 17, 2020 •
edited
Loading

Suggested merge commit message (convention)

Other: Made SpecialCharactersNavigationView an instance of the new FormHeaderView UI. See ckeditor/ckeditor5#6109.

Main PR (required): ckeditor/ckeditor5-ui#546

Additional information

BREAKING CHANGES:

  • From now the SpecialCharactersNavigationView is an instance of the FormHeaderView.
  • We removed unnecessary SpecialCharactersNavigationView#labelView.

@jodator jodator self-assigned this Mar 26, 2020
jodator
jodator approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jodator jodator merged commit 342a536 into master Mar 26, 2020
@jodator jodator deleted the i/6109 branch March 26, 2020 12:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jodator jodator jodator approved these changes

Assignees

@jodator jodator

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panr @jodator