This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Position of table cell properties balloon should be in relation to multiple selected cells. #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ltiple selected cells.
jodator
suggested changes
Mar 30, 2020
src/ui/utils.js
Outdated
| // @param {Array.<module:utils/dom/rect~Rect>|Array.<*>} list List of `Rect`s or any list to map by `mapFn`. | ||
| // @param {Function} [mapFn] Mapping function for list elements. | ||
| // @returns {module:utils/dom/rect~Rect} | ||
| function createBoundingRect( list, mapFn = null ) { |
There was a problem hiding this comment.
The null default value isn't tested (coverage dropped):
The other branch is below.
jodator
suggested changes
Mar 30, 2020
There was a problem hiding this comment.
The solution is good but some cod style issues to change:
- API usage - we have some methods for scenarios as first/last position or number of ranges in the selection.
- Although helper method and it is a private code it looks like it might be promoted to general API (not yet I think) so it must be simplified and be focused on doing one thing (calculating sum of rects).
- The
elseblock can be in most cases avoided.
src/ui/utils.js
Outdated
| const viewTableCell = editor.editing.mapper.toViewElement( modelTableCell ); | ||
| const mapper = editor.editing.mapper; | ||
| const domConverter = editor.editing.view.domConverter; | ||
| const ranges = Array.from( editor.model.document.selection.getRanges() ); |
There was a problem hiding this comment.
That's not needed at this point. You can use: editor.model.document.selection.rangeCount in the if below.
src/ui/utils.js
Outdated
| positions: BALLOON_POSITIONS | ||
| }; | ||
| } else { | ||
| const modelTableCell = getTableCellAtPosition( ranges[ 0 ].start ); |
There was a problem hiding this comment.
ranges[ 0 ].start => editor.document.selection.getFirstPosition()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Position of table cell properties balloon should be in relation to multiple selected cells. Closes ckeditor/ckeditor5#6357.
Additional information