This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
t/ckeditor5-ui/394: Used a solid box-shadow to indicate the :focus state of the .ck-button
#187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k-button (also .ck-input). Obsoleted the background color change on .ck-button:focus to avoid situations when a focused button looks like an active one (see ckeditor/ckeditor5-ui#394).
dkonopka
reviewed
Jul 4, 2018
| @@ -23,6 +23,7 @@ | |||
| /* This is important to stay of the same height as surrounding buttons */ | |||
| min-height: var(--ck-ui-component-min-height); | |||
|
|
|||
| /* Apply some smooth transition to the box-shadow and border. */ | |||
| transition-property: box-shadow,border; | |||
There was a problem hiding this comment.
Missing space before second property.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Used a solid
box-shadowto indicate the:focusstate of the.ck-button(also.ck-input). Obsoleted the background color change on.ck-button:focusto avoid situations when a focused button looks like an active one (see ckeditor/ckeditor5#5456).BREAKING CHANGE: Various color variables
--ck-color-button-...-focushave been renamed to--ck-color-button-...-hover.Additional information
A piece of ckeditor/ckeditor5-ui#422.