Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Commit

Permalink
Merge pull request #366 from ckeditor/t/112
Browse files Browse the repository at this point in the history
Other: CSS classes should be prefixed with `ck-` instead of `cke-`. Closes #112.
  • Loading branch information
Reinmar authored Feb 6, 2018
2 parents f38ae70 + 4dac786 commit 7973f83
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions src/editorui/boxed/boxededitoruiview.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export default class BoxedEditorUIView extends EditorUIView {
role: 'application',
dir: 'ltr',
lang: locale.language,
'aria-labelledby': `cke-editor__aria-label_${ ariaLabelUid }`
'aria-labelledby': `ck-editor__aria-label_${ ariaLabelUid }`
},

children: [
Expand Down Expand Up @@ -106,8 +106,8 @@ export default class BoxedEditorUIView extends EditorUIView {

voiceLabel.extendTemplate( {
attributes: {
id: `cke-editor__aria-label_${ ariaLabelUid }`,
class: 'cke-voice-label'
id: `ck-editor__aria-label_${ ariaLabelUid }`,
class: 'ck-voice-label'
}
} );

Expand Down
4 changes: 2 additions & 2 deletions tests/editorui/boxed/boxededitoruiview.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@ describe( 'BoxedEditorUIView', () => {
expect( view.element.classList.contains( 'ck-rounded-corners' ) ).to.be.true;
expect( element.attributes[ 'aria-labelledby' ].value )
.to.equal( view.element.firstChild.id )
.to.match( /^cke-editor__aria-label_\w+$/ );
.to.match( /^ck-editor__aria-label_\w+$/ );
} );

it( 'bootstraps the voice label from template', () => {
const voiceLabel = view.element.firstChild;

expect( voiceLabel.classList.contains( 'cke-voice-label' ) ).to.be.true;
expect( voiceLabel.classList.contains( 'ck-voice-label' ) ).to.be.true;
expect( voiceLabel.textContent ).to.equal( 'Rich Text Editor' );
} );

Expand Down
2 changes: 1 addition & 1 deletion theme/components/label/label.css
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@
display: block;
}

.cke-voice-label {
.ck-voice-label {
display: none;
}

0 comments on commit 7973f83

Please sign in to comment.