-
Notifications
You must be signed in to change notification settings - Fork 18
t/95: Remove the Controller class #100
Conversation
@@ -22,10 +22,14 @@ export default class View { | |||
/** | |||
* Creates an instance of the {@link ui.View} class. | |||
* | |||
* TODO: A simple example how to create one. | |||
* | |||
* @param {utils.Locale} [locale] The {@link core.editor.Editor#locale editor's locale} instance. | |||
*/ | |||
constructor( locale ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember we talked about View taking attributes
object as a second parameter, so one can easily initialize multiple observable creating a view class. I'm not sure do we need to make it generic, so should such parameter be in the base View
class or in specific views, if needed.
…o _parentElement.
…Mixin listenTo()/stopListening().
I decided to merge all this code to master and review it there because we risk having too many conflicts too quickly and blocking ourselves. 3 of you worked on these changes, all tests pass, CC is 100%, so let's not keep the world (:D) waiting. |
I finished the review. I haven't found many things, which is great taken the size of the refactoring. I wrote down everything in https://github.com/ckeditor/ckeditor5-ui/issues/103. Kudos guys! |
Closes ckeditor/ckeditor5#5266.