-
Notifications
You must be signed in to change notification settings - Fork 18
Introduced FakePanels for ContextualBalloon. #498
Conversation
@dkonopka JS part is done. You can make it beautiful now :) |
It might be because of the shadow, but the first the space between the real panel and the first fake panel looks smaller than spaces between other fake panels: Maybe we should add shadow to all panels or move it to the last one? Also, I believe we need some animation to make the impression that panels switches. Maybe they should move behind the main panel and back to their positions when switching? Or... something. Anything ;) Also, maybe we should try to add some transparency to these fake panels? |
Also, I think you should create a dedicated ticket in https://github.com/ckeditor/ckeditor5-ui/ repository for this issue. |
Maybe we could even limit it to 3 panels (1 real panel and 2 fake panels). Now, when 4 panels are displayed (1 real and 3 fake) it looks like too many. |
I'm a little late to the party, but is it actually necessary that we display those other balloons at all? After all, there's a switcher at the top so it's hard to miss that. Plus, it's not actually super correct how we display them (e.g. that all of them change their height when you go to the next one and that their placement is a bit virtual too). Don't get me wrong – it's a really nice touch and could be made really useful (e.g. clicking/hovering the ones below could somehow show a preview of their content). I'm rather worried whether this isn't an overkill for now. |
TBH I'm not a fan of these panels in the current shape too. Besides, it doesn't look good for small balloons like a toolbar. |
We agreed that we will:
|
⏫ cc @dkonopka |
…g BalloonPanelView dimension.
Suggested merge commit message (convention)
Other: Improved UX of ContextualBalloon with multiple stacks. Closes ckeditor/ckeditor5#5509.
Additional information
Required:
ckeditor5-theme-lark#cf/2808
ckeditor/ckeditor5-theme-lark#229For example – encountered issues, assumptions you had to make, other affected tickets, etc.