This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
T/22: Move image upload feature to ckeditor5-image package. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…createUploadAdapter()`.
…-no-upload-adapter`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Removed image upload feature. Closes ckeditor/ckeditor5#2800.
BREAKING CHANGE: Renamed
AdaptertoUploadAdapter.BREAKING CHANGE: Removed
ImageUploadplugin. It can be no found in ckeditor5-image repository.BREAKING CHANGE: Removed
ImageUploadEngineplugin. It can be no found in ckeditor5-image repository.BREAKING CHANGE: Removed
ImageUploadProgressplugin. It can be no found in ckeditor5-image repository.BREAKING CHANGE: Removed
ImageUploadButtonplugin. It can be no found in ckeditor5-image repository.BREAKING CHANGE: Renamed
FileRepository#createAdapter()toFileRepository#createUploadAdapter().BREAKING CHANGE: Renamed
filerepository-no-adaptererror tofilerepository-no-upload-adapter.Additional information
This PR required tests and docs changes in other repos (centralized in: https://github.com/ckeditor/ckeditor5/tree/t/ckeditor5-upload/22) - the main repo also needs changes without last commit.
The image PR has all the changes in the API:
ImageUploadfeature to ckeditor5-image package. ckeditor5-image#173Merge commit message for related branches: