Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility issues in tests #4899

Closed
maxbarnas opened this issue Aug 24, 2016 · 5 comments
Closed

Compatibility issues in tests #4899

maxbarnas opened this issue Aug 24, 2016 · 5 comments
Assignees
@maxbarnas
Labels
package:utils type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 3

Comments

@maxbarnas
Copy link
Contributor

Related: #312.
@maxbarnas maxbarnas self-assigned this Aug 24, 2016
@maxbarnas
Copy link
Contributor Author

maxbarnas commented Aug 24, 2016 •
edited
Loading

Test in https://github.com/ckeditor/ckeditor5-utils/blob/master/tests/unicode.js#L11 fails because of regexp test returning false in https://github.com/ckeditor/ckeditor5-utils/blob/master/src/unicode.js#L29.

I noticed two things so far:

  • Using RegExp constructor instead of inline regex helps a little,
  • babelified code of the the test is mangled,
  • the same code from isSurrogateHalf in Safari's console works fine.

I would be happy to use RegExp constructor and call it a day, but when using it a lot of other tests fail. This needs further checking.

@Reinmar
Copy link
Member

Reinmar commented Aug 26, 2016

:/ We should report an issue to Babel after confirming that this is really a bug.

@Reinmar
Copy link
Member

Reinmar commented Sep 14, 2016

Could you handle reporting it to Babel?

@maxbarnas
Copy link
Contributor Author

@Reinmar Yep, I will report it.

@maxbarnas
Copy link
Contributor Author

Seems it is already reported: babel/babel#3826.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-utils Oct 9, 2019
@mlewand mlewand added this to the iteration 3 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". package:utils labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxbarnas maxbarnas

Labels
package:utils type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 3
Development

No branches or pull requests
3 participants
@Reinmar @maxbarnas @mlewand