Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FF, Safari] Fix compatibility errors in tests #312

Closed
maxbarnas opened this issue Aug 23, 2016 · 4 comments
Closed

[FF, Safari] Fix compatibility errors in tests #312

maxbarnas opened this issue Aug 23, 2016 · 4 comments
Assignees
Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone

Comments

@maxbarnas
Copy link
Contributor

Related: #201.

Failed automatic tests:

  • Edge - 41
  • Safari 9 - 39
  • Firefox - 23
  • Chrome - 1
  • Opera - 1
@maxbarnas maxbarnas added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". labels Aug 23, 2016
@maxbarnas maxbarnas added this to the iteration 3 milestone Aug 23, 2016
@maxbarnas maxbarnas self-assigned this Aug 23, 2016
@maxbarnas
Copy link
Contributor Author

Results of tests

Series of fixes were made:

Manual tests needed polyfill. Related PR will be published soon.

Firefox

  • Unit tests
    • Enabling selectionchange event (which is soon to be enabled by default) solves last batch of failing tests
  • Manual tests
    • No problems found

Safari

Edge

  • Unit tests
  • Manual tests
    • Editor runs, but there are plenty of unexpected behaviours, e.g. bolding selection that starts and the beginning of the line deletes that text

IE 11

@Reinmar
Copy link
Member

Reinmar commented Sep 15, 2016

Super, thanks for the detailed output.

@Reinmar
Copy link
Member

Reinmar commented Sep 15, 2016

@Reinmar
Copy link
Member

Reinmar commented Sep 16, 2016

The enter command mentioned above is a regression on master, so it doesn't count. So the only failing test is the one in the link package. Let's move it to a separate ticket.

And for now, it means that we have FF and Safari clean with the exception of:

So I'm closing this ticket as done (for FF and Safari).

@Reinmar Reinmar closed this as completed Sep 16, 2016
@Reinmar Reinmar changed the title Fix compatibility errors in tests [FF, Safari] Fix compatibility errors in tests Sep 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

3 participants