This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
t/201: Bulletproofed isDomNode helper when used in iframes. Removed isWindow logic. #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…long with isWindow in DOMEmitterMixin.
Reinmar
reviewed
Nov 24, 2017
| return !!( obj && isNative( obj.addEventListener ) ); | ||
| if ( obj ) { | ||
| if ( obj.defaultView ) { | ||
| return obj instanceof obj.defaultView.Document; |
There was a problem hiding this comment.
Sorry, I actually wanted to know whether this code is needed at all and whether this code is semantically correct. But now I see that both things are true.
|
The existing
That may be some direction to consider if the one proposed by you in this PR will turn to be incorrect one day. Something like this should do the job: isDomNode( obj ) {
return Object.prototype.toString.apply( obj ).startsWith( '[object HTML' );
} |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Bulletproofed
isDomNodehelper when used in iframes. RemovedisWindowlogic from the helper. Closes ckeditor/ckeditor5#4985.