This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Fix exception that occur after dragging the selection through the image #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ma2ciek
changed the title
szymonkups
approved these changes
Dec 13, 2017
Reinmar
reviewed
Dec 13, 2017
| startContainerRect.width = 0; | ||
| let startContainer = range.startContainer; | ||
|
|
||
| if ( startContainer.nodeType === Node.TEXT_NODE ) { |
There was a problem hiding this comment.
Would be good to have an isText() util for that.
There was a problem hiding this comment.
Actually, we have it in the DomConverter already :D And we use similar logic in scroll.js. So at least scroll.js and now rect.js should use it. DomConverter not necessarily.
There was a problem hiding this comment.
Can I make the above change as a follow-up?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Added fallback for
Rect.getDomRangeRects()if the given range starts in text node. Closes ckeditor/ckeditor5#5416.