This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
t/6: Basic DOM utils. #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param {Object} attributes Object keys will become attributes keys and object values will became attributes values. | ||
| * @param {Node|String|Array.<Node|String>} children Child or array of children. Strings will be automatically turned | ||
| * into Text nodes. | ||
| * @returns {Element} Created element. |
There was a problem hiding this comment.
Missing @method utils.dom.foo in all files
|
Reviewed, and it's OK. I haven't run tests though – make sure it's green ;). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ckeditor/ckeditor5#4864.