This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Function getOptimalPosition should prefer positions inside viewport a… #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd not lock on first not optimal position (because of intersection flipping between viewport and limiter for different position).
|
cc @ckeditor/qa-team Could you test this PR? This function is used for positioning:
|
|
Tested in all browsers, looks good 👍 |
oleq
reviewed
Apr 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nd not lock on first not optimal position
(because of intersection flipping between viewport and limiter for different position).
Suggested merge commit message (convention)
Fix: Balloon panels should prefer positions inside viewport . Closes ckeditor/ckeditor5#6181.
Additional information