Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the content styles generator script #10299

Closed
pomek opened this issue Aug 4, 2021 · 3 comments · Fixed by #10369
Closed

Split the content styles generator script #10299

pomek opened this issue Aug 4, 2021 · 3 comments · Fixed by #10369
Assignees
Labels
squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@pomek
Copy link
Member

pomek commented Aug 4, 2021

Provide a description of the task

Currently, the Content styles generator detects new plugins (introduced between the script executions) and prepares the content styles (https://github.com/ckeditor/ckeditor5/blob/master/docs/builds/guides/integration/content-styles.md).

To use the {@exec...} tag, the script must be split into two parts:

  • a script that detects new plugins - it will be called once per a release
  • a script that prepares the content styles CSS file

Once it's done, we can use {@exec...} for reading the CSS file and inserting its content directly in the guide.

@pomek pomek added type:task This issue reports a chore (non-production change) and other types of "todos". squad:platform Issue to be handled by the Platform team. labels Aug 4, 2021
@pomek
Copy link
Member Author

pomek commented Aug 11, 2021

TODO: Review release notes (notion).

@pomek
Copy link
Member Author

pomek commented Aug 11, 2021

  • The script for displaying new plugins should ask about committing the updated plugin database.

@przemyslaw-zan przemyslaw-zan self-assigned this Aug 12, 2021
@pomek pomek added this to the iteration 46 milestone Aug 13, 2021
pomek added a commit that referenced this issue Aug 18, 2021
Other: The content styles stylesheet for the guide will be generated now on-demand using the `{@exec...}` feature. Closes #10299.

Internal: Split the content styles generator script into two parts: prepare the stylesheet and detect new plugins between iterations.
@pomek
Copy link
Member Author

pomek commented Aug 18, 2021

TODO: Review release notes (notion).

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants