-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It's impossible to focus the toolbar with the keyboard in the source editing mode #10368
Comments
The poorman's solution would be simply to add Now, the better idea would be to improve keystroke handler so that the keystrokes (hotkeys) could specify a context where a given keystroke is viable. This way toolbar focus could be registered like:
And for instance keystrokes that make sense only in editable would be registered like that:
Having that said let's go with poorman's solution as long as we don't have other cases that would benefit from contexts. |
Sounds good! 👍 FYI: tracking this at https://www.drupal.org/project/drupal/issues/3283800 😊 |
…-toolbar-v2 Feature (core): Enabled toolbar focusing and navigation across various editor implementations and features. Closes #10368. Closes #5146. Closes #9906. Closes #10025. BREAKING CHANGE (ui): The `enableToolbarKeyboardFocus()` helper has been removed. Please use the [`EditorUI#addToolbar()`](https://ckeditor.com/docs/ckeditor5/latest/api/module_core_editor_editorui-EditorUI.html#function-addToolbar) method instead to enable accessible toolbar navigation (and focusing) using `Alt+F10` and `Esc` keystrokes (see #10368).
📝 Provide a description of the improvement
Related - #9906.
If you'd like to see this improvement implemented, add a 👍 reaction to this post.
The text was updated successfully, but these errors were encountered: