Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac multiline text replacement shortcuts not working #11443

Closed
slotterbackW opened this issue Mar 9, 2022 · 1 comment · Fixed by #12795
Closed

Mac multiline text replacement shortcuts not working #11443

slotterbackW opened this issue Mar 9, 2022 · 1 comment · Fixed by #12795
Labels
squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@slotterbackW
Copy link

slotterbackW commented Mar 9, 2022

📝 Provide detailed reproduction steps (if any)

On macs, you can create multiline text replacement shortcuts. (See accepted answer here: https://superuser.com/questions/1541755/multi-line-text-replacement-on-macos-or-ios). When using these shortcuts in CKEditor the shortcuts aren't expanded.

For example, if my shortcut is: mline which is replaced with:

make

multiline

magic

(Only the first line of the shortcut is displayed)
image

then when using that shortcut in CKEditor:
Screen Shot 2022-03-09 at 12 06 54 PM

the result is:
Screen Shot 2022-03-09 at 12 06 58 PM

✔️ Expected result

The shortcut is expanded and all lines are entered into the editor.
image

❌ Actual result

Only the first line is inserted:
Screen Shot 2022-03-09 at 12 06 58 PM

❓ Possible solution

I'm pretty sure Apple doesn't really support multiline shortcuts, however, you can sort've trick the text replacement input field into using a multiline shortcut by seperating lines with soft-breaks. My guess is that something with the soft-break is messing up some logic in CKEditor.

📃 Other details

  • Browser: Chrome Version 98.0.4758.109 (Official Build) (x86_64)
  • OS: macOS Big Sur 11.6.2
  • First affected CKEditor version: …
  • Installed CKEditor plugins: was able to reproduce on the classic editor build

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@slotterbackW slotterbackW added the type:bug This issue reports a buggy (incorrect) behavior. label Mar 9, 2022
@jswiderski jswiderski added the support:2 An issue reported by a commercially licensed client. label Apr 1, 2022
@jswiderski
Copy link

jswiderski commented Apr 1, 2022

I have checked the problem and the MAC feature is working fine inside native contenteditable element or CKEditor 4 but not in CKEditor 5.

NOTES:

@Reinmar Reinmar added the squad:core Issue to be handled by the Core team. label Apr 4, 2022
Reinmar added a commit that referenced this issue Nov 16, 2022
Feature (engine): Improved support for dictation (via VoiceControl) on iOS and multi-line text replacements on macOS. Closes #2045. Closes #11443.
@CKEditorBot CKEditorBot added this to the iteration 59 milestone Nov 16, 2022
pomek pushed a commit that referenced this issue Nov 18, 2022
Feature (engine): Improved support for dictation (via VoiceControl) on iOS and multi-line text replacements on macOS. Closes #2045. Closes #11443.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants