Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image alternative text presence should be conveyed to the user #12268

Closed
mlewand opened this issue Aug 13, 2022 · 2 comments · Fixed by #12409
Closed

Image alternative text presence should be conveyed to the user #12268

mlewand opened this issue Aug 13, 2022 · 2 comments · Fixed by #12409
Assignees
Labels
domain:accessibility This issue reports an accessibility problem. domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:image squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@mlewand
Copy link
Contributor

mlewand commented Aug 13, 2022

📝 Provide detailed reproduction steps (if any)

Currently the end user has no idea whether an alternative text is applied to a certain image or not.

  1. Open full featured example for the latest release.
  2. Focus the first image.
  3. Change alternative text to non-empty value.

✔️ Expected result

The fact that the image has an alternative text should be conveyed to the user with UI.

In addition to that let's change the button name to "Image text alternative".

❌ Actual result

No information is present.

❓ Possible solution

IMO just marking the UI button as isOn would be sufficient and consistent with how ImageCaption, TableCaption and the alikes are doing this:

For describing link state we even go extra mile. Not only we're setting isOn to true on link button, but there's this little "status" icon in the top-right corner of the image:

📃 Other details

  • Browser: Any
  • OS: Any

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@mlewand mlewand added type:bug This issue reports a buggy (incorrect) behavior. intro Good first ticket. package:image domain:ui/ux This issue reports a problem related to UI or UX. domain:accessibility This issue reports an accessibility problem. labels Aug 13, 2022
@oleq
Copy link
Member

oleq commented Aug 16, 2022

I suppose it makes sense 👍

On a side note, we could also spend some time on the UI icon. This was the best we came up with years ago but maybe we could do a little bit better now. It looks awfully similar to the show/hide icon but it shouldn't.

@mlewand
Copy link
Contributor Author

mlewand commented Aug 29, 2022

On a side note, we could also spend some time on the UI icon. This was the best we came up with years ago but maybe we could do a little bit better now. It looks awfully similar to the show/hide icon but it shouldn't.

That's ok but it's a separate issue.

@mlewand mlewand added the squad:features Issue to be handled by the Features team. label Aug 30, 2022
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Aug 30, 2022
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. labels Sep 1, 2022
mlewand added a commit that referenced this issue Sep 6, 2022
…xt-presence

Fix (image): Alternative text button now indicates whether any value is applied. Closes #12268.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Sep 6, 2022
@CKEditorBot CKEditorBot added this to the iteration 57 milestone Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:accessibility This issue reports an accessibility problem. domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:image squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants