Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwitchButtonView text should not change color when it is on #12519

Closed
oleq opened this issue Sep 27, 2022 · 0 comments · Fixed by #12544
Closed

SwitchButtonView text should not change color when it is on #12519

oleq opened this issue Sep 27, 2022 · 0 comments · Fixed by #12544
Assignees
Labels
domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:list package:ui squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.

Comments

@oleq
Copy link
Member

oleq commented Sep 27, 2022

📝 Provide detailed reproduction steps (if any)

In https://ckeditor5.github.io/docs/nightly/ckeditor5/latest/examples/builds-custom/full-featured-editor.html.

  1. Create a numbered list.
  2. Open the numbered list properties drop-down.
  3. Toggle the reversed order switch

✔️ Expected result

The text stays black. The moving colorful switch is enough to carry the the state change.

❌ Actual result

2022-09-27 16 38 33

❓ Possible solution

I suppose we broke it while working on the a11y of the interface (icons getting a blueish color when the button is on). It's funny though, this bug is not visible in link decorator feature and find and replace settings where SwitchButtonView is also used. This is probably due to the fact that these features bring their own styles that (for whatever the reason) override the text color of switch buttons.

Long story short:

  1. This needs to be fixed at switchbutton.css level in theme-lark.
  2. It would be great if we knew why link decorators and find and replace are not affected. Maybe there's something else going on we don't understand?

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@oleq oleq added type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases. package:ui domain:ui/ux This issue reports a problem related to UI or UX. package:list intro Good first ticket. labels Sep 27, 2022
@mlewand mlewand added the squad:features Issue to be handled by the Features team. label Sep 28, 2022
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Sep 28, 2022
@mateuszzagorski mateuszzagorski self-assigned this Sep 29, 2022
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Sep 29, 2022
oleq added a commit that referenced this issue Sep 30, 2022
…t-color-change

Fix (theme-lark): The `SwitchButtonView`'s text and background color should stay the same regardless of the state because the toggle switch carries all necessary information. Closes #12519.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Sep 30, 2022
@CKEditorBot CKEditorBot added this to the iteration 58 milestone Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:list package:ui squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants