Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Problem with sticky toolbar placement on mobile #1348

Closed
jodator opened this issue Nov 9, 2018 · 2 comments
Closed

[Docs] Problem with sticky toolbar placement on mobile #1348

jodator opened this issue Nov 9, 2018 · 2 comments
Assignees
@oleq
Labels
package:ui type:bug This issue reports a buggy (incorrect) behavior. type:docs This issue reports a task related to documentation (e.g. an idea for a guide).
Milestone
iteration 21

Comments

@jodator
Copy link
Contributor

jodator commented Nov 9, 2018

Cross posting since we're not sure which side is responsible (Umberto or CKE5):

2018-11-09 13 01 33
@jodator jodator added type:bug This issue reports a buggy (incorrect) behavior. status:confirmed package:ui labels Nov 9, 2018
@Reinmar Reinmar added this to the iteration 21 milestone Nov 9, 2018
@Reinmar
Copy link
Member

Reinmar commented Nov 9, 2018

This is tricky. We need to know whether the docs are rendered in a narrow viewport or normal and reconfigure the toolbar offset.

@Reinmar Reinmar added the type:docs This issue reports a task related to documentation (e.g. an idea for a guide). label Nov 9, 2018
@Reinmar Reinmar changed the title Problem with sticky toolbar placement on mobile [Docs] Problem with sticky toolbar placement on mobile Nov 9, 2018
@Reinmar
Copy link
Member

Reinmar commented Nov 15, 2018 •
edited
Loading

PS. I'd ignore for now the case when someone resizes the viewport. Let's only care about the initial width.

This was referenced Nov 20, 2018
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Reinmar added a commit to ckeditor/ckeditor5-alignment that referenced this issue Nov 20, 2018
@Reinmar
Merge branch t/ckeditor5/1348
b055a46 
Docs: Fixed toolbar top offset on narrow screens. See ckeditor/ckeditor5#1348.
Reinmar added a commit to ckeditor/ckeditor5-autoformat that referenced this issue Nov 20, 2018
@Reinmar
Merge branch t/ckeditor5/1348
f704e00 
Docs: Fixed toolbar top offset on narrow screens. See ckeditor/ckeditor5#1348.
Reinmar added a commit to ckeditor/ckeditor5-basic-styles that referenced this issue Nov 20, 2018
@Reinmar
Merge branch t/ckeditor5/1348
54236e1 
Docs: Fixed toolbar top offset on narrow screens. See ckeditor/ckeditor5#1348.
Reinmar added a commit to ckeditor/ckeditor5-heading that referenced this issue Nov 20, 2018
@Reinmar
Merge branch t/ckeditor5/1348
90a042c 
Docs: Fixed toolbar top offset on narrow screens. See ckeditor/ckeditor5#1348.
Reinmar added a commit to ckeditor/ckeditor5-highlight that referenced this issue Nov 20, 2018
@Reinmar
Merge branch t/ckeditor5/1348
966f78a 
Docs: Fixed toolbar top offset on narrow screens. See ckeditor/ckeditor5#1348.
Reinmar added a commit to ckeditor/ckeditor5-font that referenced this issue Nov 20, 2018
@Reinmar
Merge branch t/ckeditor5/1348
bc7746e 
Docs: Fixed toolbar top offset on narrow screens. See ckeditor/ckeditor5#1348.
Reinmar added a commit to ckeditor/ckeditor5-image that referenced this issue Nov 20, 2018
@Reinmar
Merge branch t/ckeditor5/1348
25be8e0 
Docs: Fixed toolbar top offset on narrow screens. See ckeditor/ckeditor5#1348.
Reinmar added a commit to ckeditor/ckeditor5-link that referenced this issue Nov 20, 2018
@Reinmar
Merge branch t/ckeditor5/1348
cc4fecb 
Docs: Fixed toolbar top offset on narrow screens. See ckeditor/ckeditor5#1348.
Reinmar added a commit to ckeditor/ckeditor5-media-embed that referenced this issue Nov 20, 2018
@Reinmar
Merge branch t/ckeditor5/1348
606b9d6 
Docs: Fixed toolbar top offset on narrow screens. See ckeditor/ckeditor5#1348.
Reinmar added a commit to ckeditor/ckeditor5-table that referenced this issue Nov 20, 2018
@Reinmar
Merge branch t/ckeditor5/1348
28b3542 
Docs: Fixed toolbar top offset on narrow screens. See ckeditor/ckeditor5#1348.
Reinmar added a commit to ckeditor/ckeditor5-theme-lark that referenced this issue Nov 20, 2018
@Reinmar
Merge branch t/ckeditor5/1348
3d5a653 
Docs: Fixed toolbar top offset on narrow screens. See ckeditor/ckeditor5#1348.
Reinmar added a commit to ckeditor/ckeditor5-ui that referenced this issue Nov 20, 2018
@Reinmar
Merge branch t/ckeditor5/1348
47046eb 
Docs: Fixed toolbar top offset on narrow screens. See ckeditor/ckeditor5#1348.
Reinmar added a commit that referenced this issue Nov 20, 2018
@Reinmar
Merge pull request #1360 from ckeditor/t/1348
0afa7d6 
Docs: The `config.toolbar.viewportTopOffset` should have the right value in all snippets when using the mobile layout. Closes #1348.

Created a snippet helper file containing the `getViewportTopOffsetConfig()` function. Loaded the helper in all snippets.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:ui type:bug This issue reports a buggy (incorrect) behavior. type:docs This issue reports a task related to documentation (e.g. an idea for a guide).
Projects
None yet
Milestone
iteration 21
Development

No branches or pull requests
3 participants
@Reinmar @jodator @oleq