-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CKEditor5 as dependency #145
Comments
That would be it I guess. Don't forget about tests ( |
Thanks for the insights. I'll get them when beautifying PR. |
Finally checked. Both builds are equal for |
@Reinmar I've just fund that guppy or dev/tasks are too aggressive. They installed hooks in top-level repo (probably before I've made changes in t/145 branch). I'll check that also. |
Can't this ticket be closed now after #262? |
As the project will be used by others it would be nice to have:
gulp buil
gulp build
aware of directory structure (as for now it assumes that allckeditor5-*
repositories are innode_modules
folder ofckeditor5
repository)gulp
tasks optional (ie. currently some tasks reads.gitignore
file that is not present when ckeditor is installed as some project's dependency vianpm install
)The text was updated successfully, but these errors were encountered: