Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backspacing on Android with Samsung keyboard misplaces the caret #14707

Closed
dtdesign opened this issue Aug 1, 2023 · 4 comments · Fixed by #16289
Closed

Backspacing on Android with Samsung keyboard misplaces the caret #14707

dtdesign opened this issue Aug 1, 2023 · 4 comments · Fixed by #16289
Labels
browser:android domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). package:typing squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@dtdesign
Copy link

dtdesign commented Aug 1, 2023

📝 Provide detailed reproduction steps (if any)

  1. Open the online demo using Android with the Samsung keyboard.
  2. Type some text into the editor ending with the word test
  3. Try to backspace the last letter of test by hitting the backspace key once.
Screen_Recording_20230727_083942_Chrome.mp4

✔️ Expected result

The trailing t should be removed with the caret being placed behind tes.

❌ Actual result

The trailing t is removed, but the caret advanced by another character and is now between te and s. The editor will now look like this: te|s where the | denotes the caret position.

❓ Possible solution

This sounds an awful lot like #14567 which is similar but no the same.

📃 Other details

  • Browser: Chrome 114
  • OS: Android 13
  • First affected CKEditor version: Unknown
  • Installed CKEditor plugins: Not relevant

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@dtdesign dtdesign added the type:bug This issue reports a buggy (incorrect) behavior. label Aug 1, 2023
@Witoso Witoso added package:typing browser:android domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). squad:core Issue to be handled by the Core team. labels Aug 1, 2023
@dtdesign
Copy link
Author

These “reverse typing” issues are more widespread than I thought, we’re receiving reports of users every 1-2 days in the last few weeks. Is there something we can do to either mitigate the issue or to help you identify the root cause of it?

@Witoso
Copy link
Member

Witoso commented Dec 18, 2023

Is it "reverse typing" after the deletion? I thought it's moving the caret by one, but when typing the letters, they will be in the correct order.

@dtdesign
Copy link
Author

I’m sorry, I confused the issues.

There are actually three distinct issues on Android that we have received repeated reports for recently:

It’s sometimes a bit annoying to figure out what exactly is going wrong because these reports are mostly from users of our customers. This adds a lot of “latency” when asking for more information and the instructions to reproduce the issue are often imprecise.

@niegowski
Copy link
Contributor

The work for this issue and others related is completed in the #16289, and we finalized the round of internal (successful) tests. I encourage everyone to test the PR if you have a chance. It should be merged in the following days, and will be a part of the next release.

niegowski added a commit that referenced this issue Jul 3, 2024
Fix (typing, engine): Predictive text should not get doubled while typing. Closes #16106.

Fix (engine): The reverse typing effect should not happen after the focus change. Closes #14702. Thanks, @urbanspr1nter!

Fix (engine, typing): Typing on Android should avoid modifying DOM while composing. Closes #13994. Closes #14707. Closes #13850. Closes #13693. Closes #14567. Closes: #11569.
@CKEditorBot CKEditorBot added this to the iteration 77 milestone Jul 3, 2024
@pomek pomek modified the milestones: iteration 77, iteration 76 Jul 4, 2024
eliandoran pushed a commit to TriliumNext/trilium-ckeditor5 that referenced this issue Nov 8, 2024
Fix (typing, engine): Predictive text should not get doubled while typing. Closes ckeditor#16106.

Fix (engine): The reverse typing effect should not happen after the focus change. Closes ckeditor#14702. Thanks, @urbanspr1nter!

Fix (engine, typing): Typing on Android should avoid modifying DOM while composing. Closes ckeditor#13994. Closes ckeditor#14707. Closes ckeditor#13850. Closes ckeditor#13693. Closes ckeditor#14567. Closes: ckeditor#11569.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser:android domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). package:typing squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants