Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We can remove 'use strict' since we use ES6 modules #149

Closed
Reinmar opened this issue May 4, 2016 · 4 comments
Closed

We can remove 'use strict' since we use ES6 modules #149

Reinmar opened this issue May 4, 2016 · 4 comments
Assignees
@maxbarnas
Labels
intro Good first ticket. type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 2

Comments

@Reinmar
Copy link
Member

Reinmar commented May 4, 2016

AFAIR (needs to be confirmed) ES6 modules enable strict mode out of the box.
@Reinmar Reinmar added type:improvement This issue reports a possible enhancement of an existing feature. module:project labels May 4, 2016
@oskarwrobel
Copy link
Contributor

According to documentation http://www.ecma-international.org/ecma-262/6.0/#sec-strict-mode-code

Module code is always strict mode code.

So looks like we can remove 'use strict' from source code, but probably we need to add it automatically to CommonJS and AMD versions of builded packages.

We can also configure eslint for it http://eslint.org/docs/rules/strict

@Reinmar
Copy link
Member Author

Reinmar commented May 11, 2016 •
edited
Loading

Thanks for confirming this.

We can also configure eslint for it http://eslint.org/docs/rules/strict

We use JSHint (and JSCS). However, since JSCS is being merged to ESLint we'll have to migrate some day.

@Reinmar Reinmar added the intro Good first ticket. label Jun 7, 2016
@Reinmar Reinmar mentioned this issue Jun 14, 2016
Closed
@Reinmar
Copy link
Member Author

Reinmar commented Jun 15, 2016

TODO: Update https://github.com/ckeditor/ckeditor5-design/wiki/Code-Style#strict-mode.

@maxbarnas maxbarnas self-assigned this Jul 4, 2016
@maxbarnas maxbarnas added this to the iteration 2 milestone Jul 11, 2016
@maxbarnas maxbarnas mentioned this issue Jul 12, 2016
Merged
Reinmar added a commit that referenced this issue Jul 19, 2016
@Reinmar
Removed use strict in all ES6 modules and fixed related files. See #149.
cfbe868
Reinmar added a commit to ckeditor/ckeditor5-basic-styles that referenced this issue Jul 19, 2016
@Reinmar
Removed use strict in all ES6 modules and fixed related files. See ck…
21477d0 
…editor/ckeditor5#149.
Reinmar added a commit to ckeditor/ckeditor5-editor-classic that referenced this issue Jul 19, 2016
@Reinmar
Removed use strict in all ES6 modules and fixed related files. See ck…
809580e 
…editor/ckeditor5#149.
Reinmar added a commit to ckeditor/ckeditor5-enter that referenced this issue Jul 19, 2016
@Reinmar
Removed use strict in all ES6 modules and fixed related files. See ck…
ad50f46 
…editor/ckeditor5#149.
Reinmar added a commit to ckeditor/ckeditor5-heading that referenced this issue Jul 19, 2016
@Reinmar
Removed use strict in all ES6 modules and fixed related files. See ck…
856523a 
…editor/ckeditor5#149.
Reinmar added a commit to ckeditor/ckeditor5-paragraph that referenced this issue Jul 19, 2016
@Reinmar
Removed use strict in all ES6 modules and fixed related files. See ck…
4f0bc6c 
…editor/ckeditor5#149.
Reinmar added a commit to ckeditor/ckeditor5-theme-lark that referenced this issue Jul 19, 2016
@Reinmar
Removed use strict in all ES6 modules and fixed related files. See ck…
a53b9a0 
…editor/ckeditor5#149.
Reinmar added a commit to ckeditor/ckeditor5-typing that referenced this issue Jul 19, 2016
@Reinmar
Removed use strict in all ES6 modules and fixed related files. See ck…
305ef1c 
…editor/ckeditor5#149.
Reinmar added a commit to ckeditor/ckeditor5-ui that referenced this issue Jul 19, 2016
@Reinmar
Removed use strict in all ES6 modules and fixed related files. See ck…
c423240 
…editor/ckeditor5#149.
Reinmar added a commit to ckeditor/ckeditor5-ui-default that referenced this issue Jul 19, 2016
@Reinmar
Removed use strict in all ES6 modules and fixed related files. See ck…
9f1cbe0 
…editor/ckeditor5#149.
Reinmar added a commit to ckeditor/ckeditor5-undo that referenced this issue Jul 19, 2016
@Reinmar
Removed use strict in all ES6 modules and fixed related files. See ck…
454dfe4 
…editor/ckeditor5#149.
Reinmar added a commit to ckeditor/ckeditor5-utils that referenced this issue Jul 19, 2016
@Reinmar
Removed use strict in all ES6 modules and fixed related files. See ck…
ef0d691 
…editor/ckeditor5#149.
Reinmar added a commit to ckeditor/ckeditor5-engine that referenced this issue Jul 19, 2016
@Reinmar
Removed use strict in all ES6 modules and fixed related files. See ck…
4cea4c3 
…editor/ckeditor5#149.
@Reinmar
Copy link
Member Author

Reinmar commented Jul 19, 2016

Wiki updated: https://github.com/ckeditor/ckeditor5-design/wiki/Code-Style/_compare/c5276b3bec1bcd7a8f8408c2cf0be0e3d6735417...466587838d548bb9e716eb67e32c2575719c840d

@Reinmar Reinmar mentioned this issue Sep 14, 2016
Open
bendemboski pushed a commit to PatentNavigation/ckeditor5-typing-v19 that referenced this issue Aug 18, 2020
@Reinmar
Removed use strict in all ES6 modules and fixed related files. See ck…
55cfb0a 
…editor/ckeditor5#149.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxbarnas maxbarnas

Labels
intro Good first ticket. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 2
Development

No branches or pull requests
5 participants
@Reinmar @fredck @oskarwrobel @maxbarnas @szymonkups