Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use up and down arrow key after adding a link #1501

Closed
elliarbtan opened this issue Feb 1, 2019 · 10 comments
Closed

Cannot use up and down arrow key after adding a link #1501

elliarbtan opened this issue Feb 1, 2019 · 10 comments
Assignees
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@elliarbtan
Copy link

Is this a bug report or feature request? (choose one)

🐞 Bug report

💻 Version of CKEditor

https://ckeditor.com/docs/ckeditor5/latest/examples/builds/classic-editor.html
as of 1 february 2019.

📋 Steps to reproduce

  1. write text
  2. select some and use the "link" button or Ctrl-k
  3. try up and down navigation key

✅ Expected result

up goes up, down goes down

❎ Actual result

up and down keys have no effect

📃 Other details that might be useful

firefox 60.4.0esr (64 bits)

@oleq oleq added type:bug This issue reports a buggy (incorrect) behavior. status:confirmed labels Feb 5, 2019
@oleq oleq added this to the iteration 22 milestone Feb 5, 2019
@oleq
Copy link
Member

oleq commented Feb 5, 2019

Confirmed in 65.0. This is pretty serious actually. The arrow keys movement is also locked after moving the selection somewhere else after inserting the link. The URL input preview (?) is also displayed like the focus never left the balloon.

kapture 2019-02-05 at 10 58 06

@Reinmar
Copy link
Member

Reinmar commented Feb 6, 2019

Is it a regression?

@oleq
Copy link
Member

oleq commented Feb 13, 2019

Same in 11.1.1.

@Reinmar Reinmar changed the title cannot use up and down arrow key after adding a link Cannot use up and down arrow key after adding a link Feb 13, 2019
@oskarwrobel
Copy link
Contributor

Disabling autocomplete for the link input solves the issue but it's a workaround, not a fix.
It could be an FF issue, I'll prepare a sample with input and editable out of CKE5 to check this out.

@oskarwrobel
Copy link
Contributor

FF has some problems with blur when focused element is removed from DOM (https://github.com/ckeditor/ckeditor5-link/issues/193).

@oskarwrobel
Copy link
Contributor

It's possible to reproduce this issue outside of the CKE5. When focused input is removed from the DOM then focus partially stays in this removed input?! When there is an autocomplete it takes control over the arrow keys. I'm afraid it won't be possible to fix it without some hacks.

@oskarwrobel
Copy link
Contributor

@oskarwrobel
Copy link
Contributor

Reported https://bugzilla.mozilla.org/show_bug.cgi?id=1527628.

@oskarwrobel
Copy link
Contributor

It turns out the fix is very simple. All we need to do is blur the input (focus the other element) before removing it.

@oskarwrobel
Copy link
Contributor

We should fix it also for the ImageTextAlternative balloon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

4 participants