-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images can't be selected inside tables in certain scenarios #1523
Comments
@Reinmar to be 100% sure - it's a single image in table cell that cannot be selected, right? |
Yes. And the problem is that fake selection isn't created at all in those cases. Just like we noticed for inline widgets. |
Another one: #1524 I'm going to review those changes with inline widgets now :D |
The PRs for inline widgets don't help here. This is a separate issue. After some more investigation, it turned out that it is reproducible when clicking on an image in a blurred table cell (when the selection is in another cell or outside table). It's not visible when the image is the only/first element of that cell because then it gets automatically selected when the browser tries to make a collapsed selection at the beginning of that cell. This issue can be caused by the order in which we render things. I guess that it may look like this:
|
Fix: Fake selection container should be correctly appended to the new editable element when creating a new fake selection in a different editable element than the one which was focused before. Closes [ckeditor/ckeditor5#1523](ckeditor/ckeditor5#1523).
The text was updated successfully, but these errors were encountered: