Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paragraph is created inside paragraph when pressing Enter on a selected inline widget #1529

Closed
Reinmar opened this issue Feb 13, 2019 · 2 comments
Closed

Paragraph is created inside paragraph when pressing Enter on a selected inline widget #1529

Reinmar opened this issue Feb 13, 2019 · 2 comments
Assignees
@oskarwrobel
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 22

Comments

@Reinmar
Copy link
Member

Reinmar commented Feb 13, 2019

  1. Go to http://localhost:8125/ckeditor5-widget/tests/manual/inline-widget.html
  2. Select an inline widget.
  3. Press enter.
  4. Check the model/DOM structure. You will find a paragraph inside a paragraph (or other block element).
@Reinmar Reinmar added the type:bug This issue reports a buggy (incorrect) behavior. label Feb 13, 2019
@Reinmar Reinmar added this to the iteration 22 milestone Feb 13, 2019
@Reinmar
Copy link
Member Author

Reinmar commented Feb 13, 2019 •
edited
Loading

The demo comes from https://github.com/ckeditor/ckeditor5-widget/pull/70/files and related PRs (listed in the former one).

@oskarwrobel
Copy link
Contributor

oskarwrobel commented Feb 15, 2019 •
edited
Loading

It's caused by the widget enter handler

https://github.com/ckeditor/ckeditor5-widget/blob/40de72828d9d57e3d9a59c1d1c0d32bc7f1610ba/src/widget.js#L274-L279

@oskarwrobel oskarwrobel self-assigned this Feb 15, 2019
@oskarwrobel oskarwrobel mentioned this issue Feb 15, 2019
Merged
oleq added a commit to ckeditor/ckeditor5-widget that referenced this issue Feb 18, 2019
@oleq
Merge pull request #74 from ckeditor/t/ckeditor5/1529
847d2ab 
Fix: Pressing <kbd>Enter</kbd> should split parent element when the inline widget is inside a `$block`. Closes ckeditor/ckeditor5#1529.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskarwrobel oskarwrobel

Labels
type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 22
Development

No branches or pull requests
3 participants
@Reinmar @oskarwrobel @oleq