Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Multi-root editor crashes after focusing the image #1676

Closed
Mgsy opened this issue Apr 4, 2019 · 2 comments
Closed

[Docs] Multi-root editor crashes after focusing the image #1676

Mgsy opened this issue Apr 4, 2019 · 2 comments
Assignees
@oskarwrobel
Labels
type:bug This issue reports a buggy (incorrect) behavior. type:docs This issue reports a task related to documentation (e.g. an idea for a guide).
Milestone
iteration 23

Comments

@Mgsy
Copy link
Member

Mgsy commented Apr 4, 2019

Is this a bug report or feature request? (choose one)

🐞 Bug report

💻 Version of CKEditor

Latest master

📋 Steps to reproduce

  1. Open the multi-root editor sample in the documentation page on the latest master.
  2. Focus the image.

✅ Expected result

The image is focused properly.

❎ Actual result

The editor crashes.

📃 Other details that might be useful

GIF

bug_cke5

Error

ckeditorerror.js:46 Uncaught CKEditorError: cannot-change-view-tree: Attempting to make changes to the view when it is in an incorrect state: rendering or post-fixers are in progress. This may cause some unexpected behavior and inconsistency between the DOM and the view. Read more: https://ckeditor.com/docs/ckeditor5/latest/framework/guides/support/error-codes.html#error-cannot-change-view-tree

    at Fr.change (http://192.168.1.46:8080/build/docs/ckeditor5/latest/snippets/examples/multi-root-editor/snippet.js:4:122523)
    at e (http://192.168.1.46:8080/build/docs/ckeditor5/latest/snippets/examples/multi-root-editor/snippet.js:4:274322)
    at Fr.<anonymous> (http://192.168.1.46:8080/build/docs/ckeditor5/latest/snippets/examples/multi-root-editor/snippet.js:4:274543)
    at Fr.<anonymous> (http://192.168.1.46:8080/build/docs/ckeditor5/latest/snippets/examples/multi-root-editor/snippet.js:4:31867)
    at Fr.fire (http://192.168.1.46:8080/build/docs/ckeditor5/latest/snippets/examples/multi-root-editor/snippet.js:4:33261)
    at Fr.set [as isRenderingInProgress] (http://192.168.1.46:8080/build/docs/ckeditor5/latest/snippets/examples/multi-root-editor/snippet.js:4:46280)
    at Fr._render (http://192.168.1.46:8080/build/docs/ckeditor5/latest/snippets/examples/multi-root-editor/snippet.js:4:123677)
    at Fr.<anonymous> (http://192.168.1.46:8080/build/docs/ckeditor5/latest/snippets/examples/multi-root-editor/snippet.js:4:120223)
    at Fr.fire (http://192.168.1.46:8080/build/docs/ckeditor5/latest/snippets/examples/multi-root-editor/snippet.js:4:33261)
    at Fr.change (http://192.168.1.46:8080/build/docs/ckeditor5/latest/snippets/examples/multi-root-editor/snippet.js:4:123061)

It's a regression.
@Mgsy Mgsy added type:bug This issue reports a buggy (incorrect) behavior. status:confirmed type:docs This issue reports a task related to documentation (e.g. an idea for a guide). labels Apr 4, 2019
@Mgsy Mgsy added this to the iteration 23 milestone Apr 4, 2019
@oskarwrobel oskarwrobel self-assigned this Apr 4, 2019
@mlewand mlewand self-assigned this Apr 4, 2019
@mlewand
Copy link
Contributor

mlewand commented Apr 4, 2019

First bad commit ckeditor/ckeditor5-utils@5140c2c

@mlewand mlewand removed their assignment Apr 4, 2019
@oleq
Copy link
Member

oleq commented Apr 4, 2019

Oooppsss... 😛

@oskarwrobel oskarwrobel mentioned this issue Apr 4, 2019
Merged
@jodator jodator mentioned this issue Apr 4, 2019
Closed
pjasiun pushed a commit to ckeditor/ckeditor5-ui that referenced this issue Apr 5, 2019
Merge pull request #477 from ckeditor/t/ckeditor5/1676
17e86f9 
Fix: Fixed `View#render` collision when moving focus from a one editable to the other in multi-root editor. Closes ckeditor/ckeditor5#1676.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskarwrobel oskarwrobel

Labels
type:bug This issue reports a buggy (incorrect) behavior. type:docs This issue reports a task related to documentation (e.g. an idea for a guide).
Projects
None yet
Milestone
iteration 23
Development

No branches or pull requests
4 participants
@oskarwrobel @oleq @mlewand @Mgsy