Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RWD of the examples gives strange results #5598

Closed
Reinmar opened this issue Oct 16, 2019 · 0 comments · Fixed by #5609
Closed

RWD of the examples gives strange results #5598

Reinmar opened this issue Oct 16, 2019 · 0 comments · Fixed by #5609
Assignees
@dkonopka
Labels
type:bug This issue reports a buggy (incorrect) behavior. type:docs This issue reports a task related to documentation (e.g. an idea for a guide).
Milestone
iteration 27 (v15...

Comments

@Reinmar
Copy link
Member

Reinmar commented Oct 16, 2019

I know that no one is resizing the browser window like that IRL, but:

  • developers are testing CKE5 so they may do that,
  • it's actually kinda a mistake that when the ToC space disappears, the editor gets that wide,
  • there's a point where the editor overflows the viewport and that's docs' issue IMO

Oct-16-2019 12-32-02

Also, this would be nice to improve. I think the max width can be further increased because now the editor will nicely adjust to that. As long as the "paper sheet" displayed in the editor has a constant width, this is fine.

image
@Reinmar Reinmar added type:docs This issue reports a task related to documentation (e.g. an idea for a guide). type:bug This issue reports a buggy (incorrect) behavior. labels Oct 16, 2019
@Reinmar Reinmar added this to the iteration 27 milestone Oct 16, 2019
@Reinmar Reinmar mentioned this issue Oct 16, 2019
Closed
@dkonopka dkonopka mentioned this issue Oct 17, 2019
Merged
oleq added a commit that referenced this issue Oct 17, 2019
@oleq
Merge pull request #5609 from ckeditor/i/5598
6a869ff 
Docs: Improved RWD of the demos in the "Examples" section. Closes #5598.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkonopka dkonopka

Labels
type:bug This issue reports a buggy (incorrect) behavior. type:docs This issue reports a task related to documentation (e.g. an idea for a guide).
Projects
None yet
Milestone
iteration 27 (v15.0.0)
Development

Successfully merging a pull request may close this issue.

[Docs] Improved RWD of demos in Examples section ckeditor/ckeditor5
2 participants
@Reinmar @dkonopka