Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not having all arrows in the special chars arrows section #6167

Closed
Reinmar opened this issue Jan 30, 2020 · 2 comments · Fixed by #12440
Closed

Why not having all arrows in the special chars arrows section #6167

Reinmar opened this issue Jan 30, 2020 · 2 comments · Fixed by #12440
Assignees
Labels
intro Good first ticket. package:special-characters squad:collaboration Issue to be handled by the Collaboration team. type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@Reinmar
Copy link
Member

Reinmar commented Jan 30, 2020

So, we do have an example in the docs how to add additional arrows:

https://github.com/ckeditor/ckeditor5-special-characters/blob/master/docs/features/special-characters.md#adding-characters-to-an-existing-category

But why don't we actually add those pretty default arrows to the default arrows preset?

Also, when we do that, we need to figure out some new example.

cc @pomek @oleq


If you'd like to see this improvement implemented, add a 👍 reaction to this post.

@Reinmar Reinmar added type:improvement This issue reports a possible enhancement of an existing feature. status:discussion package:special-characters labels Jan 30, 2020
@oleq
Copy link
Member

oleq commented Feb 3, 2020

Yeah, what we have in "Arrows" category at this moment is a very limited set and it doesn't even have the most common arrows.

image

So this is how I see this:

  1. Let's make sure all common arrows are in the category (compare with popular word processors so users feel familiar with our choices).
  2. Let's use something else in the guide. I think adding greek letters (α, β, Δ) to the mathematical category would be fine.
  3. Let's review other categories for similar mistakes.

@Reinmar Reinmar modified the milestones: iteration 30, next Feb 18, 2020
@mlewand mlewand added the intro Good first ticket. label Mar 18, 2020
@pomek pomek modified the milestones: next, nice-to-have Nov 10, 2020
@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
@scofalik scofalik added the squad:collaboration Issue to be handled by the Collaboration team. label Sep 2, 2022
@CKEditorBot CKEditorBot added status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Sep 5, 2022
@DawidKossowski
Copy link
Contributor

DawidKossowski commented Sep 8, 2022

Generally, there are a lot of categories in special characters which are not included by default (comparing with most popular editors). However, most of them are very specific, like Braille or Musical, and shouldn't be as default in CKEditor. But, in my opinion, there is at least one category which could be very useful:  Emoji and could be added as a separate plugin.

During this issue I will add all common arrows to the category and update the user guide.

scofalik added a commit that referenced this issue Sep 8, 2022
Other (special-characters): Added missing arrow characters (↑, →, ↓, ←). Closes #6167.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Sep 8, 2022
@CKEditorBot CKEditorBot added this to the iteration 57 milestone Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
intro Good first ticket. package:special-characters squad:collaboration Issue to be handled by the Collaboration team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants