-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data processors should not be created with the editing view document #6381
Labels
package:editor-balloon
package:editor-classic
package:editor-decoupled
package:editor-inline
package:engine
type:bug
This issue reports a buggy (incorrect) behavior.
Milestone
Comments
Note: after this change, |
Remember to update the tutorial about creating your own editor. I think the same code was used there. |
Reinmar
added a commit
to ckeditor/ckeditor5-engine
that referenced
this issue
Mar 12, 2020
Other: `DataController` will now use a single instance of the view document for all its operations (`DataController#viewDocument`). Closes ckeditor/ckeditor5#6381.
Reinmar
added a commit
to ckeditor/ckeditor5-core
that referenced
this issue
Mar 12, 2020
Internal: Aligned to changes in ckeditor/ckeditor5#6381.
Reinmar
added a commit
to ckeditor/ckeditor5-editor-balloon
that referenced
this issue
Mar 12, 2020
Internal: Aligned to changes in ckeditor/ckeditor5#6381.
Reinmar
added a commit
to ckeditor/ckeditor5-editor-classic
that referenced
this issue
Mar 12, 2020
Internal: Aligned to changes in ckeditor/ckeditor5#6381.
Reinmar
added a commit
to ckeditor/ckeditor5-editor-decoupled
that referenced
this issue
Mar 12, 2020
Internal: Aligned to changes in ckeditor/ckeditor5#6381.
Reinmar
added a commit
to ckeditor/ckeditor5-editor-inline
that referenced
this issue
Mar 12, 2020
Internal: Aligned to changes in ckeditor/ckeditor5#6381.
Reinmar
added a commit
to ckeditor/ckeditor5-ui
that referenced
this issue
Mar 12, 2020
Internal: Aligned to changes in ckeditor/ckeditor5#6381.
Reinmar
added a commit
to ckeditor/ckeditor5-watchdog
that referenced
this issue
Mar 12, 2020
Internal: Aligned to changes in ckeditor/ckeditor5#6381.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
package:editor-balloon
package:editor-classic
package:editor-decoupled
package:editor-inline
package:engine
type:bug
This issue reports a buggy (incorrect) behavior.
Currently we do this in editors:
Which makes no sense. Why passing the editing document to the data processor used in the data pipepline?
The problem is that
DataController
does not have its own document right now. It creates its document on the fly intoView()
. This will need to be changed soDataController#constructor()
exposes its#viewDocument
. When creating a data processor you will do this:Note: Unfortunately, there will be no symmetry between the editing and data controllers. In the former, we keep only the view instance. In the latter, we won't have such an instance – we'll keep the view document directly in the controller. We discussed this with @scofalik and decided to go with this imperfect solution as we don't know yet if we'll ever need that view and what will be its shape (it's related to the performance optimization proposed by @scofalik to not recreate the entire view document on every
editor.getData()
).The text was updated successfully, but these errors were encountered: