Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor doesn't work when using Symbol polyfil #6489

Closed
dovydaskukalis opened this issue Mar 24, 2020 · 2 comments · Fixed by ckeditor/ckeditor5-utils#328
Closed

Editor doesn't work when using Symbol polyfil #6489

dovydaskukalis opened this issue Mar 24, 2020 · 2 comments · Fixed by ckeditor/ckeditor5-utils#328
Labels
package:utils type:bug This issue reports a buggy (incorrect) behavior.

Comments

@dovydaskukalis
Copy link

📝 Provide detailed reproduction steps (if any)

Due to this issue babel/babel#6010, the editor fails to initiate because this always returns true even when it shouldn't. Another piece of code with the same issue is here. Changing observablePropertiesSymbol in this to this[observablePropertiesSymbol] and observablePropertiesSymbol in observable to observable[observablePropertiesSymbol] makes the editor work fine.

I am aware it only supports modern browsers however without these changes it does not work on mobile apps built with Meteor or any other tool that adds this polyfil. As it's a simple fix, please consider making these changes 🙂

✔️ Expected result

Editor works with Symbol polyfil.

❌ Actual result

Editor doesn't load at all.

@dovydaskukalis dovydaskukalis added the type:bug This issue reports a buggy (incorrect) behavior. label Mar 24, 2020
@Reinmar
Copy link
Member

Reinmar commented Mar 25, 2020

Hi! Thanks for a detailed issue report. If the mentioned change solves the issue, then I think we'll be fine with it. Could you make a PR perhaps?

@dovydaskukalis
Copy link
Author

Sure, will do.

mlewand added a commit to ckeditor/ckeditor5-utils that referenced this issue Mar 26, 2020
Fix: Editor will now load correctly in environment with Symbol polyfilled. Closes ckeditor/ckeditor5#6489.
@mlewand mlewand added this to the iteration 31 milestone Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:utils type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants