Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The getPositionedAncestor() util should use HTMLElement.offsetParent instead of getComputedStyle #6573

Closed
oleq opened this issue Apr 8, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-utils#332
Closed

The getPositionedAncestor() util should use HTMLElement.offsetParent instead of getComputedStyle #6573

oleq opened this issue Apr 8, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-utils#332
Assignees
@oleq
Labels
type:improvement This issue reports a possible enhancement of an existing feature. type:performance This issue reports a performance issue or a possible performance improvement.
Milestone
iteration 31 (v19...

Comments

@oleq
Copy link
Member

oleq commented Apr 8, 2020

📝 Provide a description of the improvement

To speed-up the method used by getOptimalPosition for all floating UI elements of the UI.

If you'd like to see this improvement implemented, add a 👍 reaction to this post.
@oleq oleq added type:improvement This issue reports a possible enhancement of an existing feature. type:performance This issue reports a performance issue or a possible performance improvement. labels Apr 8, 2020
@oleq oleq mentioned this issue Apr 10, 2020
Merged
@oleq oleq self-assigned this Apr 10, 2020
@oleq oleq added this to the iteration 31 milestone Apr 10, 2020
Reinmar added a commit to ckeditor/ckeditor5-utils that referenced this issue Apr 17, 2020
@Reinmar
Merge pull request #332 from ckeditor/i/6573
7939756 
Other: The `getPositionedAncestor()` helper should use `offsetParent` instead of `getComputedStyle()` for performance reasons. Closes ckeditor/ckeditor5#6573.

MINOR BREAKING CHANGE: The `getPositionedAncestor()` helper will no longer return the passed element when it is positioned.
mlewand pushed a commit that referenced this issue May 1, 2020
@Reinmar
Merge pull request #332 from ckeditor/i/6573
f8a9363 
Other: The `getPositionedAncestor()` helper should use `offsetParent` instead of `getComputedStyle()` for performance reasons. Closes #6573.

MINOR BREAKING CHANGE: The `getPositionedAncestor()` helper will no longer return the passed element when it is positioned.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
type:improvement This issue reports a possible enhancement of an existing feature. type:performance This issue reports a performance issue or a possible performance improvement.
Projects
None yet
Milestone
iteration 31 (v19.0.0)
1 participant
@oleq