Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image size can be reset with remove format plugin #9684

Closed
FilipTokarski opened this issue May 12, 2021 · 0 comments · Fixed by #9728
Closed

Image size can be reset with remove format plugin #9684

FilipTokarski opened this issue May 12, 2021 · 0 comments · Fixed by #9728
Assignees
Labels
package:image package:remove-format squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@FilipTokarski
Copy link
Member

📝 Provide detailed reproduction steps (if any)

  1. Resize an image
  2. Select it
  3. Click remove format

Not sure if bug or rather an improvement proposal, but this may become annoying with inline images. I can imagine a situation when someone applies for example bold to some bigger selection, containing inline image. Then the user selects even bigger part of content and hits remove format to get rid of bold, but it also resets the size of the image. In such case I would assume that only the text formatting will be removed and that image size should be a separate thing here.

Example:

0_iimages5.mp4

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@FilipTokarski FilipTokarski added type:bug This issue reports a buggy (incorrect) behavior. package:image package:remove-format squad:core Issue to be handled by the Core team. labels May 12, 2021
@mateuszzagorski mateuszzagorski self-assigned this May 14, 2021
@AnnaTomanek AnnaTomanek added this to the iteration 43 milestone May 17, 2021
@mlewand mlewand modified the milestones: iteration 43, iteration 44 May 26, 2021
mlewand added a commit that referenced this issue Jun 10, 2021
MINOR BREAKING CHANGE (image): Resized images' size will no longer reset by remove format feature. The `width` model attribute in schema is no longer marked as with `isFormatting` property. Closes #9684.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:image package:remove-format squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants