Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed adjacent whole words being missed by find and replace #10796

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Conversation

przemyslaw-zan
Copy link
Member

@przemyslaw-zan przemyslaw-zan commented Nov 3, 2021

Fix (find-and-replace): Fixed adjacent whole words being missed by find and replace. Closes #10719.

@przemyslaw-zan
Copy link
Member Author

#10719 (comment)

☝️ please check Safari before accepting

@pomek
Copy link
Member

pomek commented Nov 4, 2021

☝️ please check Safari before accepting

I used Safari 15.0 on Mac and mobile. Automated tests pass.

image

image

Let me verify it also manually.

@pomek
Copy link
Member

pomek commented Nov 4, 2021

@FilipTokarski helped me with checking the older Safari (14).

04 11 2021 10:00:07.258:INFO [Safari 14.1.2 (Mac OS 10.14.6)]: Connected on socket B1Pzd-6yjGeX5qA7AAAD with id manual-3127
✔ 280 tests completed

@pomek
Copy link
Member

pomek commented Nov 4, 2021

Works as expected.

image

Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pomek pomek merged commit 5d466b5 into master Nov 4, 2021
@pomek pomek deleted the ck/10719 branch November 4, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find and replace does not find whole words that are next to each other
2 participants