Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed : Incorrect value of [aria-pressed] attribute in switch #11115 #11289

Closed
wants to merge 1 commit into from

Conversation

NaincyKumariKnoldus
Copy link

Hey @pomek @Reinmar I have tried to fix this. Please review this.
If any changes is still needed do inform me I will do that.
Thanks!
#11115

@mlewand
Copy link
Contributor

mlewand commented Feb 18, 2022

@NaincyKumariKnoldus This pull request is missing tests: please tests that cover your change. See our Contributing Code guide for more details.

@mlewand mlewand added the pending:feedback This issue is blocked by necessary feedback. label Feb 18, 2022
@mlewand
Copy link
Contributor

mlewand commented Jun 29, 2022

Hi, It's been a while since we last heard from you. We're closing this PR for now. Still, feel free provide us requested feedback, so that we can reopen this issue.

@mlewand mlewand closed this Jun 29, 2022
@mlewand mlewand added resolution:expired This issue was closed due to lack of feedback. and removed pending:feedback This issue is blocked by necessary feedback. labels Jun 29, 2022
@mlewand
Copy link
Contributor

mlewand commented Jul 21, 2022

Also, the issue has been fixed in #12047.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution:expired This issue was closed due to lack of feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants