Dropdown split button divider does not stretch 100% height of the button #12815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-not-stretch-100%-height-of-the-button
oleq
requested changes
Nov 10, 2022
packages/ckeditor5-theme-lark/theme/ckeditor5-ui/components/dropdown/splitbutton.css
Outdated
Show resolved
Hide resolved
…s-not-stretch-100%-height-of-the-button
…s-not-stretch-100%-height-of-the-button
|
I have noticed that left border is overflowed by splitter after clicking in that, this behaviour was before changes in this PR. Is this a bug?
|
oleq
approved these changes
Nov 14, 2022
oleq
deleted the
ck/10936-dropdown-split-button-divider-does-not-stretch-100%-height-of-the-button
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Ui. Dropdown split button divider will stretch to 100% of the button height. Closes #10936.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.