Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI lazy init #13066

Merged
merged 34 commits into from
Jan 9, 2023
Merged

UI lazy init #13066

merged 34 commits into from
Jan 9, 2023

Conversation

niegowski
Copy link
Contributor

@niegowski niegowski commented Dec 13, 2022

Suggested merge commit message (convention)

Other (ui): Dropdown panels, contextual balloon panels, and toolbar views are initialized on the first open to boost editor startup time. Closes #12890.

Other (widget): Widget toolbars are initialized on the first open to boost editor startup time. See #12890.

Other: The dropdown panels are initialized on the first open to boost editor startup time. See #12890.

Other (table): The table properties views are created on the first open to boost editor startup time. See #12890.

Tests: Tests updated to address lazy init of dropdowns. See #12890.

MINOR BREAKING CHANGE: The addToolbarToDropdown() and addListToDropdown() helpers create content panels on the first dropdown open. Make sure that you access the dropdown panel after the dropdown is open. See #12890.

MINOR BREAKING CHANGE: Toolbar views are filled with items on the first appearance. Make sure that you access toolbar items after the toolbar is visible. See #12890.

MINOR BREAKING CHANGE: Contextual balloon panels are created on the first appearance. See #12890.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@niegowski
Copy link
Contributor Author

UI init time reduction tested once again:

@niegowski niegowski marked this pull request as ready for review January 9, 2023 11:00
@niegowski niegowski requested a review from arkflpc January 9, 2023 11:04
@niegowski
Copy link
Contributor Author

This PR was already reviewed by @oleq from the UI arch point of view. Waiting for code review from @arkflpc.

@niegowski niegowski changed the title [WiP] UI lazy init UI lazy init Jan 9, 2023
@niegowski niegowski merged commit c276c45 into master Jan 9, 2023
@niegowski niegowski deleted the ck/12682-performance-lazy-init branch January 9, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make existing dropdowns initialize their panel content on first open
3 participants