-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI lazy init #13066
Merged
Merged
UI lazy init #13066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other (ui): Dropdown panels, contextual balloon panels, and toolbar views are initialized on the first open to boost editor startup time. Closes #12890.
Other (widget): Widget toolbars are initialized on the first open to boost editor startup time. See #12890.
Other: The dropdown panels are initialized on the first open to boost editor startup time. See #12890.
Other (table): The table properties views are created on the first open to boost editor startup time. See #12890.
Tests: Tests updated to address lazy init of dropdowns. See #12890.
MINOR BREAKING CHANGE: The
addToolbarToDropdown()
andaddListToDropdown()
helpers create content panels on the first dropdown open. Make sure that you access the dropdown panel after the dropdown is open. See #12890.MINOR BREAKING CHANGE: Toolbar views are filled with items on the first appearance. Make sure that you access toolbar items after the toolbar is visible. See #12890.
MINOR BREAKING CHANGE: Contextual balloon panels are created on the first appearance. See #12890.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.