Accessibility for Font size/family and Heading dropdowns in toolbar #13893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity-selected-state-for-dropdowns-v3
…ity-selected-state-for-dropdowns-v3
illia-stv
approved these changes
Apr 18, 2023
oleq
reviewed
Apr 18, 2023
Comment on lines
+146
to
+151
| declare public role: string | undefined; | ||
|
|
||
| /** | ||
| * @inheritDoc | ||
| */ | ||
| declare public ariaChecked: boolean | undefined; |
There was a problem hiding this comment.
Don't we need these in the Button interface as well?
There was a problem hiding this comment.
Yes we do. Added.
| type: bind.to( 'type', value => value ? value : 'button' ), | ||
| tabindex: bind.to( 'tabindex' ), | ||
| 'aria-labelledby': `ck-editor__aria-label_${ ariaLabelUid }`, | ||
| 'aria-label': bind.to( 'ariaLabel' ), | ||
| 'aria-labelledby': bind.to( 'ariaLabelledBy' ), |
There was a problem hiding this comment.
The existing test checks if aria-labelledby starts with ck-editor__aria-label. This is a default value but we also need a test to see if the new observable ariaLabelledBy property is actually observable and what it does.
Comment on lines
150
to
158
| /** | ||
| * @inheritDoc | ||
| */ | ||
| declare public ariaLabel?: string | undefined; | ||
|
|
||
| /** | ||
| * @inheritDoc | ||
| */ | ||
| declare public ariaLabelledBy: string | undefined; |
There was a problem hiding this comment.
No we don't. Last time I checked this I was getting errors regarding not implementing the interface correctly for SplitButtonView. But now it seems to work without these declarations.
| @@ -310,6 +310,7 @@ export function addListToDropdown( | |||
| itemsOrCallback: Collection<ListDropdownItemDefinition> | ( () => Collection<ListDropdownItemDefinition> ), | |||
| options: { | |||
| ariaLabel?: string; | |||
| role?: string; | |||
Comment on lines
+93
to
+94
| ariaLabel: accessibleLabel, | ||
| ariaLabelledBy: undefined, |
There was a problem hiding this comment.
These changes have no test coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (font, heading): Screen readers should now announce selected option in dropdown lists for font size, font family and heading. Closes #13250.
Additional information
There was already one solution in which we tried to implement this but it was not good enough. As described here, we decided to go with another approach.
Besides font we added here also heading feature to make sure that this time the proposed solution will cover also dropdowns with the selected value shown in the toolbar.