Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use safer way for stringifying number in CKBox categories fetcher #16726

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Use safer way for stringifying number in CKBox categories fetcher #16726

merged 1 commit into from
Jul 15, 2024

Conversation

Mati365
Copy link
Member

@Mati365 Mati365 commented Jul 15, 2024 •
edited
Loading

Suggested merge commit message (convention)

Fix (ckbox): Use a safer way to convert numbers to strings to avoid issues with some bundlers. Closes #16040

Additional information

  1. PR based on: Fix (ckbox): use safer way for stringifying numbers #16041
  2. I added unit test to prevent regressions.

@Mati365 Mati365 mentioned this pull request Jul 15, 2024
Closed
@Mati365 Mati365 requested review from illia-stv and filipsobol July 15, 2024 07:10
@Mati365 Mati365 merged commit bd13d8f into master Jul 15, 2024
3 of 6 checks passed
@Mati365 Mati365 deleted the ck/16040 branch July 15, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipsobol filipsobol filipsobol approved these changes

@illia-stv illia-stv Awaiting requested review from illia-stv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SyntaxError: Invalid or unexpected token 50.toString()
2 participants
@Mati365 @filipsobol