Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unexpected behavior in splitting cells in certain tables #16733

Merged
merged 4 commits into from
Jul 18, 2024
Merged

Fix unexpected behavior in splitting cells in certain tables #16733

merged 4 commits into from
Jul 18, 2024

Conversation

Mati365
Copy link
Member

@Mati365 Mati365 commented Jul 16, 2024 •
edited
Loading

Suggested merge commit message (convention)

Fix (table): Horizontal split button no longer splits larger table cell spans into more than two parts. Closes #14658.

Additional information

Before fix

before-split-cell-fix-2024-07-16_10.30.04.mp4

After fix

after-fix.mp4

@Mati365 Mati365 marked this pull request as ready for review July 16, 2024 08:37
@Mati365
Copy link
Member Author

Mati365 commented Jul 17, 2024

Tested by QA, no regressions.

niegowski
niegowski requested changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@niegowski niegowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest adding additional test for the original issue as it states about additional columns:

The cell splits into multiple ones. The structure of the table is further altered and an additional column gets inserted on the right

@Mati365
Copy link
Member Author

Mati365 commented Jul 17, 2024

@niegowski Ok 👍🏻

@Mati365 Mati365 requested a review from niegowski July 18, 2024 07:55
@Mati365
Copy link
Member Author

Mati365 commented Jul 18, 2024

@niegowski I added missing test https://github.com/ckeditor/ckeditor5/pull/16733/files#diff-2740fa3a0238a03b01f07a7e4f30276468e98fc43d368424925a69dbd3df9dddR1069 . It should reflect table from issue.

@niegowski niegowski merged commit 3c23755 into master Jul 18, 2024
6 checks passed
@niegowski niegowski deleted the ck/14658 branch July 18, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niegowski niegowski niegowski approved these changes

@illia-stv illia-stv Awaiting requested review from illia-stv

@arkflpc arkflpc Awaiting requested review from arkflpc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected behavior in splitting cells in certain tables
2 participants
@Mati365 @niegowski