Skip to content

Commit

Permalink
Upgrade node in Dockerfile from 12.4.0 to 12.22.10
Browse files Browse the repository at this point in the history
I personally ran issue an issue with a bug in Node TLS handling
(nodejs/node#11771). This bug was fixed in
approximately 12.14.0, and does not show up when I test with v12.22.10,
the latest v12 release at the time of this commit.

(Issue306)[skooner-k8s#306]

Test Plan: Built image locally, deployed to microk8s cluster. No longer
experiencing issue with parsing TLS certs.

Signed-off-by: Cullen Walsh <[email protected]>
  • Loading branch information
ckwalsh committed Feb 23, 2022
1 parent 4f0204a commit 2867663
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Stage 1 - the build react app
FROM node:12.4.0-alpine as build-deps
FROM node:12.22.10-alpine as build-deps
WORKDIR /usr/src/app
COPY client/package.json client/package-lock.json ./
RUN npm i
Expand All @@ -8,7 +8,7 @@ COPY client/ ./
RUN npm run build

# Stage 2 - the production environment
FROM node:12.4.0-alpine
FROM node:12.22.10-alpine

RUN apk add --no-cache tini
ENV NODE_ENV production
Expand Down

0 comments on commit 2867663

Please sign in to comment.