Fix install name in macOS wheels with install_name_tool #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I managed to break the git history when deleting a large file. Would you mind re-checking out master, copying the relevant files, and re-submitting a new PR? Sorry about the inconvenience. |
|
No problem, I updated my master by doing |
PyPI does not support internal document links (starting with #). https://stackoverflow.com/a/16594755/223267
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resulting wheels verified to work without
DYLD_LIBRARY_PATH. Just dopip install dynet.Removed
delocatebecause it doesn't work in our case (matthew-brett/delocate#22).