Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed pointers to references where nullptr is invalid #207

Merged
merged 5 commits into from
Dec 12, 2016
Merged

Changed pointers to references where nullptr is invalid #207

merged 5 commits into from
Dec 12, 2016

Conversation

mitchellstern
Copy link
Contributor

This standardizes the code base according to @neubig's suggestion in #201. A few minor warnings are also fixed.

@neubig
Copy link
Contributor

neubig commented Dec 12, 2016

Thanks! This looks good. This will break external software toolkits that rely on DyNet's C++ API, so I think we should notify people on the dynet-users mailing list, and then pull in a day or so.

@mitchellstern
Copy link
Contributor Author

Sounds good, thanks! I think the major API change to note is that all builders (e.g. all RNN and softmax variants) and all trainers now take a Model& instead of a Model* during construction. In addition, a few utility functions (e.g. in dict.h and pretrain.h) were modified to take references instead of pointers where appropriate.

@neubig neubig merged commit 97867c5 into clab:master Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants