Failed to start and restart clangd

[fonqL]

Please describe the problem.

Simply translate: Command ... resulted in an error ...

But 0.1.22 works well.

Logs
No output

System information
Clangd version (from the log, or clangd --version):

clangd version 14.0.3
Features: windows
Platform: x86_64-pc-windows-msvc

clangd extension version:
0.1.23

VScode version:
1.69.1

Operating system:
Win10

[HighCommander4]

When this happens, can you open Help --> Toggle Developer Tools, and copy what you see in the Console tab? Hopefully there is a stack trace there that gives more information about this error.

[fonqL]

vscode-app-1667030779566.log

Here are logs, but I can't find anything related to clang(d)... Hope it will help you.

[fonqL]

After debugging the extension I find my previous config clangd.path: D:\LLVM\bin\clangd is regarded as an error, and it is solved by appending .exe.
A little weird...
This problem is related to @clangd/install 0.1.16. (When I modified @clangd/install dependency version to 0.1.4 it works well)
The location of the exception is here.

Or, is it actually my fault..?
If yes, I hope it can log something or show a dialog...

[HighCommander4]

Thanks, I can reproduce the original error now.

Steps to reproduce:

1. Set clangd.path to an invalid path
2. Close and restart vscode
   ==> At this point, on vscode startup, I get a dialog saying: "The clangd binary '<path>' was not found. Would you like to download and install clangd 15.0.3"?
3. Close that dialog (without installing).
4. Perform "clangd: Restart language server"

Now I get the error:

Command 'clangd: Restart language server' resulted in an error (Cannot read properties of undefined (reading 'stop'))

The source of the error is the this.client.stop() call here. That code is triggered by 'clangd: Restart language server', and it expects this.client to be a valid object, but if clangd was not running to begin with, then it will be undefined.

This part is a vscode-clangd bug.

As for D:\LLVM\bin\clangd being an invalid path on Windows, I think that's a legitimate error. Since the filename does include the .exe, the value of clangd.path should as well. I understand it may have worked without the .exe before since some library facilities try to automatically add the .exe, it's probably not a good idea to rely on that.

Out of curiosity, do you not get the first dialog (from step 2) when starting vscode, which says "The clangd binary 'D:\LLVM\bin\clangd' was not found. Would you like to download and install clangd 15.0.3"?

[fonqL]

Yes, I've never seen the dialog even if the path doesn't exist.
I can't find any code calling promptInstall.

[HighCommander4]

I can't find any code calling promptInstall.

The code is in node-clangd

[fonqL]

I have tried my best but still have no idea.
It seems that the code after this await doesn't get executed at all. When I click next step button in that line, in typescript it just returns to here, in javascript it jumps to the end of __awaiter() in that recover function.
Debug console has no logs.
I can only guess:

1. The status has a background member which is a Promise. After await common.prepare it seems to be ignored, and its status is pending, though I don't know what it means. I try to await or .then/.catch but none of these works.
2. Network problems when accessing github cause some strange problems. But it seems never timeout or throw something.

[fonqL]

Ok I finally figured it out. It's a network and timeout problem. My vscode can't access github smoothly because of unknown reasons, and there is also no timeout parameter set in latestRelease function which is called by recover function.
I think you can reproduce by disconnecting the internet.

[HighCommander4]

Ok I finally figured it out. It's a network and timeout problem. My vscode can't access github smoothly because of unknown reasons, and there is also no timeout parameter set in latestRelease function which is called by recover function. I think you can reproduce by disconnecting the internet.

Thanks for investigating! That sounds like a second bug that we should fix in node-clangd.

[HighCommander4]

(I'm going to reopen this issue and use it to track fixes for the two vscode-clangd/node-clangd bugs we have identified.)

[HighCommander4]

Fix for the first issue: #461

[HighCommander4]

Fix for the second issue: clangd/node-clangd#23

(Though I could not reproduce the hang locally -- if I disconnect my internet then the fetch() fails immediately. That said, I'm fairly confident that adding a timeout here should address the hang.)

[fonqL]

It works, thanks a lot!

(Though I could not reproduce the hang locally -- if I disconnect my internet then the fetch() fails immediately. That said, I'm fairly confident that adding a timeout here should address the hang.)

I just found out that it is related to my network proxy.