Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression issue on the new 0.1.27 release. #599

Closed
hokein opened this issue Mar 19, 2024 · 4 comments · Fixed by #601
Closed

Regression issue on the new 0.1.27 release. #599

hokein opened this issue Mar 19, 2024 · 4 comments · Fixed by #601
Assignees
@HighCommander4
Labels
bug Something isn't working

Comments

@hokein
Copy link
Collaborator

hokein commented Mar 19, 2024

Steps:

  1. work in a cpp source file, and introduce some code that make clangd crashes.
  2. revert the change, and run clangd: restart language server command to restart clangd.

Now with 0.1.27, the restart command in 2) doesn't work -- I don't see a new instance of clangd starts. The #587 is a related change, @HighCommander4 .
@hokein hokein added the bug Something isn't working label Mar 19, 2024
@HighCommander4
Copy link
Contributor

Thanks for filing, I'll investigate.

@HighCommander4 HighCommander4 self-assigned this Mar 19, 2024
HighCommander4 added a commit to HighCommander4/vscode-clangd that referenced this issue Mar 19, 2024
@HighCommander4
Fix check for clangd.restart being a no-op
a88b6bc 
The intention was to only catch the case where the language server
is already starting because running the restart command triggered
activation of the plugin, but it was also catching the case where
the language server wasn't running at all.

Fixes clangd#599
@HighCommander4 HighCommander4 mentioned this issue Mar 19, 2024
Merged
@HighCommander4
Copy link
Contributor

Proposed fix: #601

Apologies for the regression.

@HighCommander4 HighCommander4 mentioned this issue Mar 19, 2024
Open
@HighCommander4
Copy link
Contributor

I also filed #602 as a follow-up for adding some tests for the clangd.restart command to avoid accidentally introducing regressions like this in the future.

HighCommander4 added a commit that referenced this issue Mar 19, 2024
@HighCommander4
Fix check for clangd.restart being a no-op (#601)
900eccb 
The intention was to only catch the case where the language server
is already starting because running the restart command triggered
activation of the plugin, but it was also catching the case where
the language server wasn't running at all.

Fixes #599
@hokein
Copy link
Collaborator Author

hokein commented Mar 20, 2024

Confirm that v0.1.28 release works now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HighCommander4 HighCommander4

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix check for clangd.restart being a no-op HighCommander4/vscode-clangd
2 participants
@HighCommander4 @hokein