Remove legacy semantic-highlighting client code. #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, I thought this was gone! Another relevant milestone is clangd 11, which is the first version that supports semanticTokens. (I think it's no longer possible to install new versions of the vscode-clangd on vscode versions so old they don't support semantic tokens). LG, but I think we should maybe coordinate landing this with the llvm 14 release? |
|
Going to merge this because it blocks bundling (the jsonc parser is badly behaved) |
The legacy semantic-highlighting support has been dropped since clangd13.
sam-mccall
force-pushed
the
remove-legacy-hl
branch
from
a117c2f to
a91684d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The legacy semantic-highlighting support has been dropped since clangd13.