Add tree view for recent $/memoryUsage feature in clangd. #86
Conversation
src/memory-usage.ts
Outdated
| .filter(x => !x.startsWith('_')) | ||
| .map(e => convert(m[e] as WireTree, e)) | ||
| .sort((x, y) => x.total - y.total) | ||
| .reverse(), |
There was a problem hiding this comment.
why not sort in the other way directly? (or why not sort based on title)
There was a problem hiding this comment.
You're right. The intention was to sort by [total, title] but I messed it up.
The code to sort by a compound key is awkward in JS, but sort() is stable, so we sort the titles first and then the totals.
src/memory-usage.ts
Outdated
| interface WireTree { | ||
| _self: number; | ||
| _total: number; | ||
| [child: string]: WireTree|number|string; |
There was a problem hiding this comment.
my typescript isnt so strong, but why can this be anything but WireTree ? isn't it enough to handle _self and _total explicitly? (and even if that's not enough, where does the string come from)
There was a problem hiding this comment.
_self and _total have to conform to this constraint too, unfortunately. I couldn't find a way to more precisely express the type. This is one of the reasons for mapping quickly to another type :-)
(There's a workaround involving intersection types, but they must be type rather than interface and types can't be recursive as they're just aliases).
string is a mistake (leftover from an intermediate version where I added _title)
| item.tooltip = `self=${node.self} total=${node.total}`; | ||
| if (node.isFile) | ||
| item.iconPath = new vscode.ThemeIcon('symbol-file'); | ||
| else if (!node.children.length) |
There was a problem hiding this comment.
do we intentionally not set any icons for non-leaf (and non-file) nodes?
There was a problem hiding this comment.
Correct. This is subjective, but I couldn't find an icon that seemed to add signal rather than just visual noise.
|
might be worth to mention this in https://clangd.llvm.org/extensions.html |
No description provided.