fix(complete): Suppress a useless space completion

We cannot add tests for this because white spaces are trimmed by runtime.complete().
clap-rs · Jan 4, 2024 · 22bf919 · 22bf919
1 parent 2f75e2d
commit 22bf919
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/clap_complete/src/shells/bash.rs b/clap_complete/src/shells/bash.rs
@@ -171,6 +171,7 @@ fn option_details_for_path(cmd: &Command, path: &str) -> String {
         let compopt = match o.get_value_hint() {
             ValueHint::FilePath => Some("compopt -o filenames"),
             ValueHint::DirPath => Some("compopt -o plusdirs"),
+            ValueHint::Other => Some("compopt -o nospace"),
             _ => None,
         };
 

diff --git a/clap_complete/tests/snapshots/home/static/exhaustive/bash/.bashrc b/clap_complete/tests/snapshots/home/static/exhaustive/bash/.bashrc
@@ -542,6 +542,9 @@ _exhaustive() {
                     ;;
                 --other)
                     COMPREPLY=("${cur}")
+                    if [ "${BASH_VERSINFO[0]:-0}" -ge 4 ]; then
+                        compopt -o nospace
+                    fi
                     return 0
                     ;;
                 --path)

diff --git a/clap_complete/tests/snapshots/value_hint.bash b/clap_complete/tests/snapshots/value_hint.bash
@@ -35,6 +35,9 @@ _my-app() {
                     ;;
                 --other)
                     COMPREPLY=("${cur}")
+                    if [ "${BASH_VERSINFO[0]:-0}" -ge 4 ]; then
+                        compopt -o nospace
+                    fi
                     return 0
                     ;;
                 --path)