Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes cargo features to NOT require nightly with unstable features #403

Merged
merged 2 commits into from
Jan 30, 2016

Conversation

kbknapp
Copy link
Member

@kbknapp kbknapp commented Jan 30, 2016

No description provided.

@yo-bot
Copy link

yo-bot commented Jan 30, 2016

r? @Vinatorul

(yo-bot has picked a reviewer for you, use r? to override)

@Vinatorul
Copy link
Contributor

Looks like TRAVIS_CARGO_NIGHTLY_FEATURE doesn't work.

@Vinatorul
Copy link
Contributor

May be this is because of we are using travis-cargo only for docs and benches, or I missed something?

@kbknapp
Copy link
Member Author

kbknapp commented Jan 30, 2016

@Vinatorul it looks like it, I think it's from when we pulled clippy out, which was supposed to be temporary.

Should be good now.

@kbknapp
Copy link
Member Author

kbknapp commented Jan 30, 2016

@homu r+

@homu
Copy link
Contributor

homu commented Jan 30, 2016

📌 Commit 998b0df has been approved by kbknapp

homu added a commit that referenced this pull request Jan 30, 2016
fix: fixes cargo features to NOT require nightly with unstable features
@homu
Copy link
Contributor

homu commented Jan 30, 2016

⌛ Testing commit 998b0df with merge 3067a12...

homu added a commit that referenced this pull request Jan 30, 2016
fix: fixes cargo features to NOT require nightly with unstable features
@homu
Copy link
Contributor

homu commented Jan 30, 2016

☀️ Test successful - status

@homu homu merged commit 998b0df into master Jan 30, 2016
@kbknapp kbknapp deleted the cargo-features branch January 30, 2016 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants