Fix HostsDeleteByIds request due to documentation #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix request body to delete hosts by IDs. https://www.zabbix.com/documentation/6.0/en/manual/api/reference/host/delete#:~:text=Examples-,Deleting%20multiple%20hosts,-Delete%20two%20hosts Here we don't need hostids key. So it's just converted to list of ids.
Update host requests due to documentation
Refactor HostIds
|
Oh, turns out this change broke support for Zabbix versions older than v2.2, e.g.:
I should have expanded the code below before reviewing, there's fallback code to retry without With Zabbix 6.0, the error seems to have changed from |
|
We should probably favor newer Zabbix versions, and reverse the calls to first try without |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Due to official documentation, we don't need "hostids" key. Probably it's the root cause of this issue claranet/terraform-provider-zabbix#34
https://www.zabbix.com/documentation/6.0/en/manual/api/reference/host/delete#:~:text=%22params%22%3A,%5D%2C